Unify ca name #146
Merged
Unify ca name #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
alexey-gruzdev
previously approved these changes
Aug 12, 2021
openfl/transport/grpc/client.py
Outdated
| self.private_key = private_key | ||
| self.root_ca = root_ca | ||
| self.cert = cert | ||
| self.key = key |
There was a problem hiding this comment.
Perhaps, it make sense to rename key to private_key. The meaning will be clearly in cases server.private_key or cleint.private_key instead server.key , client.key or client_args['key'].
cert -> certificate key -> private_key
aleksandr-mokrov
approved these changes
Aug 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.