General split to ShardDescriptor and ShardDataset #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandr-mokrov
force-pushed
the
shard_dataset_shard_descriptor
branch
from
732dc02
to
fcefd13
Compare
aleksandr-mokrov
requested review from
itrushkin,
dmitryagapov and
igor-davidyuk
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
…into shard_dataset_shard_descriptor
itrushkin
suggested changes
Oct 26, 2021
openfl-tutorials/interactive_api/PyTorch_Kvasir_UNet/envoy/kvasir_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
...ub/interactive_api_director/experiments/pytorch_kvasir_unet/envoy/kvasir_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Kvasir_UNet/envoy/kvasir_shard_descriptor.py
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Outdated
Show resolved
Hide resolved
openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/market_shard_descriptor.py
Show resolved
Hide resolved
…sir_shard_descriptor.py Co-authored-by: Ilya Trushkin <ilya.trushkin@intel.com>
…rket_shard_descriptor.py Co-authored-by: Ilya Trushkin <ilya.trushkin@intel.com>
…rket_shard_descriptor.py Co-authored-by: Ilya Trushkin <ilya.trushkin@intel.com>
…ir_unet/envoy/kvasir_shard_descriptor.py Co-authored-by: Ilya Trushkin <ilya.trushkin@intel.com>
dmitryagapov
approved these changes
Oct 28, 2021
# Conflicts: # openfl-tutorials/interactive_api/PyTorch_Kvasir_UNet/workspace/PyTorch_Kvasir_UNet.ipynb # openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/shard_config_one.yaml # openfl-tutorials/interactive_api/PyTorch_Market_Re-ID/envoy/shard_config_two.yaml
| @property | ||
| def sample_shape(self): | ||
| """Return the sample shape info.""" | ||
| return self._sample_shape | ||
| return ['300', '400', '3'] |
There was a problem hiding this comment.
Yeah, why we now hard code this? It is probably the only example with parametrized sample shape.
Kvasir is also probably the only example with a functioning dummy shard descriptor
There was a problem hiding this comment.
Make sense, was changed
itrushkin
approved these changes
Nov 1, 2021
igor-davidyuk
approved these changes
Nov 1, 2021
alexey-gruzdev
approved these changes
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardDescriptor is split into ShardDescriptor and ShardDataset.
ShardDescriptor is responsible for providing specific dataset by type, description, target and sample shapes. Also it responsible for downloading data for test examples.
ShardDataset is responsible for providing data. It's implements methods len and getitem.