-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting for entire openfl
namespace (including experimental)
#998
Conversation
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
This has been a tiring one. Request this be merged as soon as we can (ideally before any open feature PRs), so future PRs can make use of the updated code practices. |
openfl
namespace (including experimental)openfl
namespace (including experimental)
Signed-off-by: Shah, Karan <karan.shah@intel.com>
Signed-off-by: Shah, Karan <karan.shah@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the effort. Code looks much cleaner now. This will be nice going forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice technical debt PR!. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @MasterSkepticista! Approved and ready for merge
Pylint score before any changes: 5.45/10
Edit: Pylint score after this PR: 8.09/10
Copyright
headers in all impacted files.Reviewers, pls note:
openfl/tests/openfl/interface/test_aggregator_api.py
Lines 70 to 77 in ac3ed37