Ignore 'implicit memory aliasing' rule for Go 1.22+ #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com>
didrocks
added a commit
to ubuntu/adsys
that referenced
this pull request
Feb 22, 2024
The loopclosure is not released in gosec yet. This can be removed once securego/gosec#1108 is merged.
ccojocar
approved these changes
Mar 4, 2024
|
Can you do a release, so that this gets updated in golangci-lint? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent changes in language in Go 1.22 we no longer need to check for "implicit memory aliasing" rule. Doing:
is now valid because
itemis a new variable in memory for every iteration (and not as it was before the same variable in memory what caused all the problems).Closes: #1090