-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go modules support for 1.12 #297
Conversation
I'll fix CI using build tag for old version compatibility. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🎉 💯
@azihsoyn first of all. Thank you SO MUCH! for taking the time to submit this PR. It has been the most requested feature, and something I've not had the time to get around to. At a first glance this seems really great.
My only asks would be:
-
Can you clarify what this change would mean for Go version support? I'm happy to move with the latest but we will need to update docs / CI jobs accordingly.
-
Can you please replace the commented out tests to use
Skip()
in the body instead? I'd like to keep that showing in test output if possible as a reminder to revisit / re-evaluate them.
@ccojocar do you have any additional feedback on this?
Hi, @gcmurphy! Thanks for the review! I'll fix your pointed places ASAP😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It would be great if we could fix a few things to get the tests passing. I believe we can retrieve the parsing error from the package.
Thanks @azihsoyn! It looks great!
Yes, Let's remove the 1.9 and 1.10 from travis config. I think that we will bump the version to |
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
======================================
Coverage 56.3% 56.3%
======================================
Files 9 9
Lines 492 492
======================================
Hits 277 277
Misses 188 188
Partials 27 27
Continue to review full report at Codecov.
|
@gcmurphy Please could you have a look over this PR? I'm waiting for your thumb up before merging it. Thanks |
Thanks for review and merging! |
This PR adds support for running this tool against Go modules.
Closes #234