Fix the rule G304 to handle the case when the input is cleaned as a variable assignment #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable assignment Signed-off-by: Cosmin Cojocar <ccojocar@cloudbees.com>
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 72.70% 72.70%
=======================================
Files 9 9
Lines 674 674
=======================================
Hits 490 490
Misses 163 163
Partials 21 21 Continue to review full report at Codecov.
|
gcmurphy
reviewed
Aug 18, 2020
…the G304 rule Signed-off-by: Cosmin Cojocar <ccojocar@cloudbees.com>
|
@gcmurphy I added also the filepath.Rel to the methods accepted for sanitation. Please could you have a look again over this pull request? Thanks! |
gcmurphy
approved these changes
Aug 19, 2020
ChristoWolf
added a commit
to ChristoWolf/go-progress
that referenced
this pull request
Jul 5, 2021
…s containing that action in fimage](https://github.com/ChristoWolf/fimage/actions). Namely: - `io.Discard` is not recognized. - Using `filepath.Clean` outside of the `os.Open` call still yields the [G304](https://securego.io/docs/rules/g304.html) false positive, which has been [fixed already](securego/gosec#513). Resolves #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #506