Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]Add the G304 rule example #20

Merged
merged 1 commit into from
Apr 15, 2020
Merged

[Feat]Add the G304 rule example #20

merged 1 commit into from
Apr 15, 2020

Conversation

Aisuko
Copy link
Contributor

@Aisuko Aisuko commented Apr 15, 2020

Signed-off-by: Aisuko urakiny@gmail.com

Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aisuko Thanks for this doc contribution. It looks good. I would rephrase a bit the introduction. Please see my comment.

docs/rules/g304_file-path_provided_as_taint_input.md Outdated Show resolved Hide resolved
docs/rules/g304_file-path_provided_as_taint_input.md Outdated Show resolved Hide resolved
Signed-off-by: Aisuko <urakiny@gmail.com>
@Aisuko Aisuko requested a review from ccojocar April 15, 2020 14:27
@Aisuko
Copy link
Contributor Author

Aisuko commented Apr 15, 2020

Done

Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the review comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants