Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the newer version check #507

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

ericwb
Copy link
Contributor

@ericwb ericwb commented Jun 15, 2024

The code to check for a new version of precli has been problemmatic. It's also not strictly required feature. So this commit removes it for now. It might be revisited later.

@ericwb
Copy link
Contributor Author

ericwb commented Jun 15, 2024

Was getting this from outdated recently:

Erics-MacBook-Pro-2:precli ericwb$ .tox/py312/bin/precli asfasdf
Exception in thread Thread-1 (check):
Traceback (most recent call last):
  File "/Users/ericwb/.pyenv/versions/3.12.2/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
  File "/Users/ericwb/.pyenv/versions/3.12.2/lib/python3.12/threading.py", line 1010, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/ericwb/workspace/precli/.tox/py312/lib/python3.12/site-packages/outdated/__init__.py", line 109, in check
    is_outdated, latest = check_outdated(package, version)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ericwb/workspace/precli/.tox/py312/lib/python3.12/site-packages/outdated/__init__.py", line 36, in check_outdated
    from pkg_resources import parse_version
  File "/Users/ericwb/workspace/precli/.tox/py312/lib/python3.12/site-packages/pkg_resources/__init__.py", line 2191, in <module>
    register_finder(pkgutil.ImpImporter, find_on_path)
                    ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

The code to check for a new version of precli has been problemmatic.
It's also not strictly required feature. So this commit removes
it for now. It might be revisited later.

Signed-off-by: Eric Brown <eric.brown@securesauce.dev>
@ericwb ericwb merged commit 2ec810e into securesauce:main Jun 15, 2024
7 checks passed
@ericwb ericwb deleted the rm_outdated branch June 15, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant