Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't print stack to stdout #93

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: don't print stack to stdout #93

merged 1 commit into from
Mar 8, 2024

Conversation

lance
Copy link
Member

@lance lance commented Mar 8, 2024

Printing the stack trace could potentially reveal sensitive information from within the process. This is documented in CWE-209 (https://cwe.mitre.org/data/definitions/209.html) and is considered a High Severity weakness by prodsec. This commit removes that.

Printing the stack trace could potentially reveal sensitive information
from within the process. This is documented in CWE-209
(https://cwe.mitre.org/data/definitions/209.html) and is considered a
High Severity weakness by prodsec. This commit removes that.

Signed-off-by: Lance Ball <lball@redhat.com>
Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonPowr, lance

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit e438808 into securesign:main Mar 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants