Skip to content

Commit

Permalink
Merge pull request #299 from securesign/disable-monitoring-by-default
Browse files Browse the repository at this point in the history
Disable monitoring by default
  • Loading branch information
Gregory-Pereira committed Apr 2, 2024
2 parents f202ecf + 686d605 commit bec53c8
Show file tree
Hide file tree
Showing 13 changed files with 17 additions and 28 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ endif

# Set the Operator SDK version to use. By default, what is installed on the system is used.
# This is useful for CI or a project to utilize a specific version of the operator-sdk toolkit.
OPERATOR_SDK_VERSION ?= v1.33.0
OPERATOR_SDK_VERSION ?= v1.32.0

# Image URL to use all building/pushing image targets
ifdef IMAGE_TAG
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type ExternalAccess struct {
type MonitoringConfig struct {
// If true, the Operator will create monitoring resources
//+kubebuilder:validation:XValidation:rule=(self || !oldSelf),message=Feature cannot be disabled
//+kubebuilder:default:=true
//+kubebuilder:default:=false
Enabled bool `json:"enabled"`
}

Expand Down
2 changes: 1 addition & 1 deletion bundle.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
LABEL operators.operatorframework.io.bundle.package.v1=rhtas-operator
LABEL operators.operatorframework.io.bundle.channels.v1=alpha
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.33.0
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.32.0
LABEL operators.operatorframework.io.metrics.mediatype.v1=metrics+v1
LABEL operators.operatorframework.io.metrics.project_layout=go.kubebuilder.io/v3

Expand Down
6 changes: 3 additions & 3 deletions bundle/manifests/rhtas-operator.clusterserviceversion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,15 @@ metadata:
"enabled": true
},
"monitoring": {
"enabled": true
"enabled": false
}
},
"rekor": {
"externalAccess": {
"enabled": true
},
"monitoring": {
"enabled": true
"enabled": false
}
},
"trillian": {
Expand Down Expand Up @@ -189,7 +189,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2024-04-02T08:05:15Z"
createdAt: "2024-04-02T16:39:44Z"
operators.operatorframework.io/builder: operator-sdk-v1.32.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
name: rhtas-operator.v1.0.0
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/rhtas.redhat.com_fulcios.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ spec:
description: Enable Service monitors for fulcio
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring resources
type: boolean
x-kubernetes-validations:
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/rhtas.redhat.com_rekors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
description: Enable Service monitors for rekor
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring resources
type: boolean
x-kubernetes-validations:
Expand Down
4 changes: 2 additions & 2 deletions bundle/manifests/rhtas.redhat.com_securesigns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ spec:
description: Enable Service monitors for fulcio
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring
resources
type: boolean
Expand Down Expand Up @@ -419,7 +419,7 @@ spec:
description: Enable Service monitors for rekor
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring
resources
type: boolean
Expand Down
11 changes: 0 additions & 11 deletions bundle/metadata/annotations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,3 @@ annotations:
features.operators.openshift.io/token-auth-aws: "false"
features.operators.openshift.io/token-auth-azure: "false"
features.operators.openshift.io/token-auth-gcp: "false"

features.operators.openshift.io/disconnected: "false"
features.operators.openshift.io/fips-compliant: "false"
features.operators.openshift.io/proxy-aware: "false"
features.operators.openshift.io/cnf: "false"
features.operators.openshift.io/cni: "false"
features.operators.openshift.io/csi: "false"
features.operators.openshift.io/tls-profiles: "false"
features.operators.openshift.io/token-auth-aws: "false"
features.operators.openshift.io/token-auth-azure: "false"
features.operators.openshift.io/token-auth-gcp: "false"
2 changes: 1 addition & 1 deletion config/crd/bases/rhtas.redhat.com_fulcios.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ spec:
description: Enable Service monitors for fulcio
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring resources
type: boolean
x-kubernetes-validations:
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/rhtas.redhat.com_rekors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
description: Enable Service monitors for rekor
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring resources
type: boolean
x-kubernetes-validations:
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/rhtas.redhat.com_securesigns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ spec:
description: Enable Service monitors for fulcio
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring
resources
type: boolean
Expand Down Expand Up @@ -419,7 +419,7 @@ spec:
description: Enable Service monitors for rekor
properties:
enabled:
default: true
default: false
description: If true, the Operator will create monitoring
resources
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion config/default/manager_auth_proxy_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
capabilities:
drop:
- "ALL"
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.1
image: gcr.io/kubebuilder/kube-rbac-proxy@sha256:d4883d7c622683b3319b5e6b3a7edfbf2594c18060131a8bf64504805f875522
args:
- "--secure-listen-address=0.0.0.0:8443"
- "--upstream=http://127.0.0.1:8080/"
Expand Down
4 changes: 2 additions & 2 deletions config/samples/rhtas_v1alpha1_securesign.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
externalAccess:
enabled: true
monitoring:
enabled: true
enabled: false
trillian:
database:
create: true
Expand All @@ -30,7 +30,7 @@ spec:
organizationEmail: jdoe@redhat.com
commonName: fulcio.hostname
monitoring:
enabled: true
enabled: false
tuf:
externalAccess:
enabled: true
Expand Down

0 comments on commit bec53c8

Please sign in to comment.