-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual annotations removed by worker #483
Comments
I feel like there should be 2 sets of annotations. The manually added annotations and the ones generated by the mode's parser. I think they currently collide and erase one another... |
yeah, that's what's happening. i'm not sure if it's possible to have annotations exist outside of the lifecycle of the worker or not. |
I'm facing the same challenge. After I set my custom annotations, the worker's annotations override mine. setOptions={{useWorker: false}} Doing this diables the worker's annotation however so all my linting/syntax highlighting is gone. (not quite what I want) I want to be able to merge the worker's annotation with my custom annotation. Can someone suggest how to go about this ? |
Hi , I'm in a similar situation, unable to add custom error messages. Any solution? |
Instead of using the
|
There's a bug in the AceEditor when combining custom annotations with worker: securingsincity/react-ace#483 This patch tries to mitigate this problem with a custom method linked to the onValidate signal that checks if the custom annotaions are part of the editor annotations and adding them if they are not present. https://phabricator.endlessm.com/T30063
Problem
I'm rendering a
react-ace
component withannotations
like this:The manual annotation will show up briefly, then be removed once the worker runs.
This gif shows a page refresh. On each page load the annotation shows up, but is then removed.
I've disabled the worker with
setOptions={{useWorker: false}}
, but this also disables annotations done manually.Thanks!
The text was updated successfully, but these errors were encountered: