Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecure features #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add insecure features #1

wants to merge 1 commit into from

Conversation

lmt-swallow
Copy link
Member

This PR adds some insecure codes to main.go. These changes will result in alerts by reviewdog and semgrep.

@lmt-swallow lmt-swallow self-assigned this Feb 17, 2021
@@ -19,6 +21,9 @@ func (Tweet) TableName() string {
}

func main() {
r := rand.Int()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
Do not use math/rand. Use crypto/rand instead.

@@ -33,6 +38,15 @@ func main() {
"posts": posts,
})
})
r.GET("/search", func(c *gin.Context) {
title, _ := c.GetQuery("title")
query := fmt.Sprintf("select * from posts where title LIKE '%%%s%%'", title)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
A raw query is used: "select * from posts where title LIKE '%%%s%%'".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant