Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: tauri app #49

Merged
merged 2 commits into from Jun 12, 2023
Merged

feature: tauri app #49

merged 2 commits into from Jun 12, 2023

Conversation

leon3s
Copy link
Collaborator

@leon3s leon3s commented Jun 10, 2023

Closes #48
It's not working on linux currently.
There is an issue on it there
it should work for macos and windows, but i couldn't test it..

You need the tauri cli to test:

cargo install tauri-cli
cargo tauri dev

The yew-app and actix-api have to be started before.

image

@leon3s leon3s mentioned this pull request Jun 10, 2023
@griffobeid
Copy link
Member

This is a great first start, and thank you for your efforts on this!

I'm testing on MacOS and connecting to the server is working, heartbeats are being sent and received. I think that there is a lack of support on the web view that Tauri is using for audio and video transcoders so the Tauri app is unable to show incoming audio/video and is also not sending audio/video to the other users. Do you know if it is possible to use Chrome as the underlying web view with Tauri?

@darioalessandro
Copy link
Member

@leon3s This awesome!!! thanks for the contribution!!

@leon3s
Copy link
Collaborator Author

leon3s commented Jun 11, 2023

Do you know if it is possible to use Chrome as the underlying web view with Tauri?

I'm pretty sure you can't.
The goal of tauri is to use the current webkit of the system. Unlike electron that embed chomium.
That way the final binary is smaller.

Did you tested @darioalessandro ? I'm pretty sure it would work on recent version of Mac!
I'll be able to test on windows soon!

@leon3s
Copy link
Collaborator Author

leon3s commented Jun 11, 2023

What's up ?

Screenshot 2023-06-11 194442

Looks like it's working well on window!

@darioalessandro
Copy link
Member

Testing now

@darioalessandro darioalessandro self-requested a review June 11, 2023 20:43
@darioalessandro
Copy link
Member

This lgtm.

I do think we need to show an error for older browsers or supports that do not support webcodecs in general, I'll add a ticket to the backlog for that.

@darioalessandro
Copy link
Member

#56

<key>NSCameraUsageDescription</key>
<string>Request camera access</string>
<key>NSMicrophoneUsageDescription</key>
<string>Request microphone access</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes on a different PR but on MacOS we can use LSMinimumSystemVersion to 13.4

@darioalessandro
Copy link
Member

Screenshot 2023-06-11 at 5 56 29 PM
Even the latest MacOS is missing some classes

@leon3s
Copy link
Collaborator Author

leon3s commented Jun 12, 2023

I remove the plist and merge it then ? You got it working on your mac ?

@griffobeid
Copy link
Member

We are using some apis that safari does not support, audio encoders and media stream track processors. I think we can merge this and work on those issues separately though

@darioalessandro
Copy link
Member

@leon3s seems like AVVideoCaptureSource is not present in Safari, I am running the latest version of MacOS.

I think that we can use electron instead of Tauri for MacOS while they fix Safari.

@darioalessandro darioalessandro merged commit 33d3e5b into security-union:main Jun 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: DesktopApp with Tauri
3 participants