Factor out CameraEncoder, MicrophoneEncoder, and ScreenEncoder #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only structural change is that previously there was a single bit `destroy: Arc<AtomicBool>` that would stop all encoding when it was set, but now each Encoder has its own. Previously the `host.destroy()` method would set that bit, but now it calls a `.stop()` method for each encoder. Also: * Moved the transforms from model/mod.rs into model/encode/transform.rs since they're only used in model/encode. * Moved the wrappers from model/mod.rs into model/wrappers.rs just so that mod.rs isn't a mixed bag of submodule declarations and code definition.
|
Thanks for the contribution @ronen I tested it out locally and it looks good to me! @darioalessandro can you take a look? |
griffobeid
approved these changes
Jul 3, 2023
|
Wow !!! this is great!! I love how you moved all the model out of the host!! looking now |
|
I am sorry for taking this long! will review again by eod tomorrow July 9 |
July 9, but luckily you didn't specify a year :) Just joking around, no rush. |
XD XD sorry mate, I am on it right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Another step towards #74]
Factored out CameraEncoder, MicrophoneEncoder, and ScreenEncoder
The only structural change is that previously there was a single bit
destroy: Arc<AtomicBool>that would stop all encoding when it was set, but now each Encoder has its own. Previously thehost.destroy()method would set that bit, but now it calls a.stop()method for each encoder.Also:
Moved the transforms from model/mod.rs into model/encode/transform.rs since they're only used in model/encode.
Moved the wrappers from model/mod.rs into model/wrappers.rs just so that mod.rs isn't a mixed bag of submodule declarations and code definition.