Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autohighlight to select inputs #546

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

MarcoKorinth
Copy link

Fixes #544

Changes

  • Add autohighlight option to autocomplete components

Copy link

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work for me - neither in the CWE fields nor in the product /group id space. Have you tested it?

BTW: Is it possible to add a test?

@MarcoKorinth
Copy link
Author

Yes I tested it and it worked for me, but I will look into it again, specifically the fields you mentioned.

A simple enter key test is possible, I will add one.

@tschmidtb51
Copy link

BTW: Which browser did you use and which field for testing?

@MarcoKorinth
Copy link
Author

I used firefox and the Label of Flag field in vulnerabilities.

Turns out we use different components for autocompletion in the code.
The CWE and id inputs don't use the mui autocompletion component, so I have to refactor the other autocomplete component or implement the feature myself.

I'll look into it.

Copy link

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoKorinth MarcoKorinth merged commit 9bb2b85 into secvisogram:main Jul 18, 2024
5 checks passed
@MarcoKorinth MarcoKorinth deleted the feat/select-input-ux branch July 18, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user input support
3 participants