Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Empty ASNOrigin Lookup #216

Closed
hmajid2301 opened this issue Oct 19, 2018 · 8 comments
Closed

🐛 Empty ASNOrigin Lookup #216

hmajid2301 opened this issue Oct 19, 2018 · 8 comments
Assignees
Milestone

Comments

@hmajid2301
Copy link
Contributor

  • Python version: 3.6.6 and ipwhois: 1.0.0

Code Example

net = Net('2001:43f8:7b0::')
obj = ASNOrigin(net)
results = obj.lookup(asn='AS37578')
pprint(results)

{
"nets": [],
"query": "AS37578",
"raw": None
}

Tried this for multipe ip addresses and asns , none of them return any routes.

Tracked the issues in asn:get_nets_radb(), seems to be ipwhois response now breaks the regex.

@supriyo-biswas
Copy link

@secynic Do we have an update on when this will be fixed?

@hmajid2301
Copy link
Contributor Author

I need to update my PR i'll try to do it next week when I have some time

@secynic
Copy link
Owner

secynic commented Feb 2, 2019

@hmajid2301 Any update? Otherwise, I can take a look next week.

@hmajid2301
Copy link
Contributor Author

Sorry about the delay just had a busy last 2 weeks. Ive made another PR.

@secynic secynic added this to the 1.2.0 milestone Feb 4, 2019
@secynic
Copy link
Owner

secynic commented Feb 5, 2019

Thanks for the contribution! See my notes on fixing the PR before I merge.

@jonathan-kosgei
Copy link

Hi @secynic I just ran into this myself, when might 1.2 be out?

@secynic
Copy link
Owner

secynic commented Jul 31, 2019

Merged to dev in #234.

I found a bug in the lookup that isn't returning the first response if multiple asn_methods are provided. Additionally, #239 states that radb won't return CIDR for ASN origin anymore. It looks like it works if i remove the inet-rtr argument. Will leave this open until I can fix those things.

secynic added a commit that referenced this issue Jul 31, 2019
secynic added a commit that referenced this issue Jul 31, 2019
@secynic
Copy link
Owner

secynic commented Jul 31, 2019

Merged in #242. Please test out the dev branch.

@secynic secynic closed this as completed Aug 7, 2019
HQJaTu pushed a commit to HQJaTu/ipwhois that referenced this issue Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants