Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup_rdap with depth > 1 does not follow all entities #247

Closed
kryptlurch opened this issue Nov 6, 2019 · 3 comments · Fixed by #280
Closed

lookup_rdap with depth > 1 does not follow all entities #247

kryptlurch opened this issue Nov 6, 2019 · 3 comments · Fixed by #280
Assignees
Labels
Milestone

Comments

@kryptlurch
Copy link

kryptlurch commented Nov 6, 2019

lookup_rdap does not follow all possible entities:
example:

from ipwhois import IPWhois
obj = IPWhois('185.176.27.42')
result = obj.lookup_rdap(depth=2)

should fetch f.e. entity ORG-ISEB3-RIPE and include its details (vcard, street....)

@secynic secynic self-assigned this Mar 4, 2020
@romain-fontugne
Copy link

maybe related the org-name from RIPE NCC is missing in ipwhois results

@secynic secynic added the bug label Sep 15, 2020
@secynic
Copy link
Owner

secynic commented Sep 15, 2020

Looking into this. The ipwhois results include the entity but everything is empty for it.

Confirmed it does have data:
http://rdap.db.ripe.net/entity/ORG-ISEB3-RIPE

@secynic
Copy link
Owner

secynic commented Sep 15, 2020

Those were root level entity objects returned by the base RDAP query, so they were not considered more than depth=0. The problem was the base RDAP query didn't return the vcardArray and other info like it did for ACRO20645-RIPE.

I've added a check if vcardArray is missing. If it is, it will query those root level entities for more info.

There is a problem with this. If depth=0, in the past, you would only expect 1 RDAP query per IP. Now if those root level entities are missing info, it will have 4 HTTP queries with depth=0 in this case.

I added a new argument (root_ent_check) to optionally disable these extra lookups.

secynic added a commit that referenced this issue Sep 15, 2020
Fixed bug in root and sub-entities not getting queried/data (#247)
@secynic secynic closed this as completed Sep 15, 2020
HQJaTu pushed a commit to HQJaTu/ipwhois that referenced this issue Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants