Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional imports #100

Closed
wants to merge 8 commits into from
Closed

Conversation

yakMM
Copy link
Contributor

@yakMM yakMM commented Dec 22, 2022

Draft PR for #64

Are left to do:

  • Feature implementation
  • Discuss breaking changes
  • Write new tests
  • Update documentation

Copy link

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am not familiar with how this package works, so I cannot give a full review :)

src/grimp/adaptors/importscanner.py Show resolved Hide resolved
src/grimp/adaptors/importscanner.py Show resolved Hide resolved
@yakMM
Copy link
Contributor Author

yakMM commented Sep 29, 2023

Sorry, I am not familiar with how this package works, so I cannot give a full review :)

Thanks for the review, I'll take into account for the up-to-date PR

@yakMM
Copy link
Contributor Author

yakMM commented Sep 29, 2023

Superseded by #130

@yakMM yakMM closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants