Changes to dark theme #31
Conversation
|
Hi Justin, I actually understand which file you mean - I thought you want to update dircolors.256dark which is a 256 color theme. Instead of changing his theme, maybe we add another ansi theme? |
| .swo 93 | ||
| *,v 93 | ||
|
|
||
| # The cyan color is free for you to use for custom file types |
There was a problem hiding this comment.
Used to say brightmagenta/purple, which was wrong. For the old theme, the correct color is blue here. For my variation it's cyan.
|
Ah, I see. Yea, this is an option; I was wondering what the best route was myself. However, there are a few changes here that I think are worth having in huyz's theme. In particular, the colors I added for sticky and o+w dirs, as well as the colors for the extra, obscure filetypes. There's also a comment that needs to be fixed in his theme, which I corrected for my variation on line 455. The matter about blue vs. cyan and the ANSI bright codes is separate, and I imagine he might have reason to not desire them. In which case, I agree that a separate theme for these changes would be in order. It might even be best to undo the blue vs. cyan swap for the sake of consistency, although I'm certainly keeping it the version I personally use. Perhaps it'd be best to patch him into this discussion to get his thoughts? Alternatively, I could resubmit the pull request to his fork. |
|
ok, so we close this and you fill slightly patch the existing theme and add your new one? |
|
Hmm...well, taking a look at 256dark, that theme uses blue for dirs and cyan for links. That's the most consistent with the default ls coloring. This leaves me wondering if we should modify the ANSI themes to be consistent with that (or vice versa). It seems odd to have totally different themes for 256 and 16 color. |
Things I have done to the dark theme:
Things that need to be done if adopted:
I am not sure how widely supported the ANSI bright codes are. I have not run into any issues yet.