Rename mapping/es to storage and start using elasticsearch lib #45
Conversation
| @@ -15,7 +15,8 @@ | |||
| ], | |||
| "backend": { | |||
| "elastic": "http://4.3.2.1:9200/", | |||
There was a problem hiding this comment.
this is probably deprecated in favour of "connection", why not remove this?
There was a problem hiding this comment.
I will remove this one in a following commit in the same branch. Right now there is code, that still uses this
| logging.error( | ||
| "Got {} error when creating index '{}'.".format( | ||
| e, index_to_create)) | ||
| sys.exit(1) |
There was a problem hiding this comment.
Is this normal to immediately break running flask or gunicorn process here? Why not raise some exception instead?
There was a problem hiding this comment.
this function is called from job.py, not from flask
There was a problem hiding this comment.
So this code is not planned to be used by wsgi server?
This is actually not a good pattern to terminate python process somewhere deep in code, it is better to raise some exception
There was a problem hiding this comment.
well, I tend to agree with you. I'm coping this from it's prev location, but there's no reason not to improve this part =)
| logging.error( | ||
| "Got {} error when creating index '{}'.".format( | ||
| e, index_to_create)) | ||
| sys.exit(1) |
There was a problem hiding this comment.
So this code is not planned to be used by wsgi server?
This is actually not a good pattern to terminate python process somewhere deep in code, it is better to raise some exception
This commit renames mapping.es.py to storage.py to unify things with
other projects. This also adds initial usage of elasticsearch library
client and expands config to allow old and new code to coexist.
Closes #42
Related #37