Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong code example on Quickstart page #325

Closed
ErikNatanael opened this issue Dec 27, 2019 · 3 comments
Closed

Wrong code example on Quickstart page #325

ErikNatanael opened this issue Dec 27, 2019 · 3 comments

Comments

@ErikNatanael
Copy link

Hi! Just checking this framework out I found a little bug on your webpage:

Going straight to Quickstart through this link displays the correct code (I think), but going to Code comparison (refreshing the page or going through the About page) and clicking the right arrow, the first code example under "A little deeper" is instead the React component code from the page before. Same thing in Firefox and Chrome.

@David-OConnor
Copy link
Member

Nice find! @MartinKavik : Want to take a look when you get back? I'm not familiar with how the new site is meched.

@MartinKavik
Copy link
Member

MartinKavik commented Jan 3, 2020

@ErikNatanael Thanks for feedback!
There was a bug in the VDOM diff algorithm - see referenced PR (above this comment) for more details.
I'm closing this in favor of referenced issue in the seed-rs.org repo.


OT:
@ErikNatanael - my feedback for you:

@David-OConnor Look at the website, maybe you'll find inspiration for your next abstract picture.

@ErikNatanael
Copy link
Author

OT:
@ErikNatanael - my feedback for you:

* GitHub link on https://eriknatanael.com/about is broken.

* `plyaing` (typo) on https://eriknatanael.com/digital-musical-instruments.

* I like the website feel and this [image](https://eriknatanael.com/user/pages/04.installations/03.nature-in-the-anthropocene/02._nature-in-the-anthropocene/Nature_in_the_Anthropocene1.jpg).

@David-OConnor Look at the website, maybe you'll find inspiration for your next abstract picture.

Thank you for the feedback, that's very kind! Glad you liked the installation, I'm working on more of the growing plant visuals right now actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants