Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path spaces should be supported #515

Closed
Type1J opened this issue Aug 10, 2020 · 6 comments
Closed

Path spaces should be supported #515

Type1J opened this issue Aug 10, 2020 · 6 comments

Comments

@Type1J
Copy link

Type1J commented Aug 10, 2020

Currently, when using cargo make watch, I get the following when using my second drive:

[cargo-make] INFO - Execute Command: "cargo" "watch" "-q" "-x" "make --disable-check-for-updates --no-on-error --loglevel=info --profile=development --allow-private --skip-init-end-tasks --makefile=/Volumes/Macintosh HD2/Projects/test_seed/seed-quickstart/Makefile.toml watch"
[cargo-make][1] ERROR - Descriptor file: "/Volumes/Macintosh" not found.
[cargo-make][1] WARN - Build Failed.

It seems that the --makefile=... option doesn't quote (it would have to be a nested quote because this is already in a quote for -x), so Macintosh HD2 is interpreted as more than 1 argument.

@MartinKavik
Copy link
Member

It looks like an issue related to cargo-make, I summon its master - @sagiegurari 🙂

@sagiegurari
Copy link
Contributor

thanks will check it. hopefully tommorow

@Type1J
Copy link
Author

Type1J commented Aug 10, 2020

Thanks @MartinKavik !

@sagiegurari
Copy link
Contributor

this is now fixed in the new released cargo-make version 0.32.2

@MartinKavik
Copy link
Member

MartinKavik commented Aug 21, 2020

@Type1J Could you test it and close the issue if the problem is resolved? Thanks!

@Type1J
Copy link
Author

Type1J commented Aug 26, 2020

Sure. That machine stopped working after a thunderstorm, but it worked using the cargo-make from git, so I will close this issue, now.

I'm in the process of building a new Proxmox machine with a Linux dev VM, so it will be Linux instead of macOS that I'll be testing, but I'll be sure to come back here and reopen it, if it doesn't work as soon as I test it out.

@Type1J Type1J closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants