Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch invocation should wrap makefile path #445

Closed
sagiegurari opened this issue Aug 10, 2020 · 5 comments
Closed

watch invocation should wrap makefile path #445

sagiegurari opened this issue Aug 10, 2020 · 5 comments
Assignees
@sagiegurari
Labels
bug
Milestone
0.32.2

Comments

@sagiegurari
Copy link
Owner

seed-rs/seed#515
@sagiegurari sagiegurari self-assigned this Aug 10, 2020
@Type1J
Copy link

Type1J commented Aug 10, 2020

@sagiegurari Thanks for looking at this issue!

sagiegurari added a commit that referenced this issue Aug 11, 2020
@sagiegurari
Fix watch invocation in case makefile file path contains spaces #445
42dd918
@sagiegurari
Copy link
Owner Author

@Type1J i have a development branch 0.32.2 which might have a fix for this.
can you maybe test it as well on your use case?

@sagiegurari sagiegurari added this to the 0.32.2 milestone Aug 11, 2020
@Type1J
Copy link

Type1J commented Aug 11, 2020

I checked it out, did a

cargo uninstall cargo-make
git checkout 0.32.2
cargo install --path .
cd <place with Seed project>
cargo make start

It looks like that works. Thanks!

@sagiegurari
Copy link
Owner Author

great. thanks a lot for checking.
i have few more unrelated changes before i release a new official version.

@Phytolizer Phytolizer mentioned this issue Aug 18, 2020
Closed
sagiegurari added a commit that referenced this issue Aug 19, 2020
@sagiegurari
Improve fix for watch when makefile path contains spaces #445
89092fc
sagiegurari added a commit that referenced this issue Aug 19, 2020
@sagiegurari
Improve fix for watch when makefile path contains space #445
352afc3
@sagiegurari
Copy link
Owner Author

this is now released in the new cargo-make version 0.32.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagiegurari sagiegurari

Labels
bug
Projects
None yet
Milestone
0.32.2
Development

No branches or pull requests
2 participants
@Type1J @sagiegurari