Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependabot): ✨ add dependabot for updating Python dependencies #444

Merged
merged 1 commit into from
May 24, 2024

Conversation

martonvago
Copy link
Contributor

Description

This PR adds dependabot and configures it to update Python dependencies (managed by Poetry) in this repository.
The PRs will look something like:
python-dep

See also Issue seedcase-project/.github#24

Testing

  • Yes
  • No, not needed (give a reason below)
  • No, I need help writing them

I tested it in a minimal repo and it seemed to behave as expected.

Reviewer Focus

This PR only needs a quick review.

Checklist

For all PRs that are not general documentation

  • Tests accompany or reflect changes to the code
  • Tests ran and passed locally
  • Ran the linter and formatter
  • Build has passed locally
  • Relevant documentation has been updated

@martonvago martonvago requested a review from a team May 21, 2024 15:19
@martonvago martonvago self-assigned this May 21, 2024
directory: /
schedule:
interval: weekly
versioning-strategy: increase-if-necessary
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To update the version constraint in the manifest file only if the new version is not in range. Seems like some people prefer this because it leads to fewer updates on the whole, but I don't have any deeper insight

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work for poetry managed projects? There is no manifest file for poetry projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought pyproject.toml was the ?equivalent of the? manifest file. In any case, with increase-if-necessary pyproject.toml will only be updated if the new version is outside the range specified in pyproject.toml.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it seems that it only updates the poetry lock file: dependabot/dependabot-core#8603 which seems to be waiting on python-poetry/poetry-core#708

Maybe we wait a bit for those PRs to be merged, since it doesn't make sense to only update the lock file and not the pyproject.toml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but then I'm a bit confused about why it updated both of them in my test repo (e.g. if you look at this PR). Or am I looking at the wrong thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, that is super odd... What's the open issues for then?? Well, let's just try it out and see how it works 😋😋

@martonvago
Copy link
Contributor Author

martonvago commented May 21, 2024

I read around a bit about what some sensible default settings might be, but it's still pretty bare bones, so feel free to ignore or change.

I'm also not sure if any other future repos might want to use the same setup, in which case we might want it to be synced across them like some other files.

@martonvago martonvago marked this pull request as ready for review May 21, 2024 15:34
Copy link
Collaborator

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't know much about dependabot, but I think it's nice to start implementing it :)
@lwjohnst86 should this be in the .github repo?

@lwjohnst86 lwjohnst86 merged commit 6d342f2 into main May 24, 2024
2 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/add-dependabot branch May 24, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants