-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow secondary user backup to USB #381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grote
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I found some minor stuff and will do one last pass before merging, checking all the context usage in the places you touched to make sure we are not accidentally using the wrong context somewhere.
app/src/main/java/com/stevesoltys/seedvault/ui/storage/RestoreStorageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/ui/storage/StorageRootResolver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/ui/storage/StorageRootResolver.kt
Show resolved
Hide resolved
storage/lib/src/main/java/org/calyxos/backup/storage/plugin/saf/SafStoragePlugin.kt
Show resolved
Hide resolved
this is the error when save storage is not executed |
By default, Android exposes USB devices only to the main user. In order to query, read and write to it, the signature permission INTERACT_ACROSS_USERS_FULL (optional) is granted to create Seedvault's context as the system user. Issue: calyxos#437 Issue: #77 Change-Id: I0b1b4c8c5aeeb226419ff94e15f631ebe1db66df
The storage plugin cannot find USB backups for secondary users if it is not saved before checking if backups exist
grote
reviewed
Mar 31, 2022
app/src/main/java/com/stevesoltys/seedvault/ui/storage/StorageRootResolver.kt
Show resolved
Hide resolved
Incidentally this gets rid of the need to pass an implementation-specific Uri to the StoragePlugin.
chirayudesai
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Android exposes USB devices only to the main user.
In order to query, read and write to it, the signature permission INTERACT_ACROSS_USERS_FULL (optional) is granted to create Seedvault's context as the system user.
Change-Id: I0b1b4c8c5aeeb226419ff94e15f631ebe1db66df
Issue: calyxos#437
Issue: #77