You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're using bookshelf as an ORM solution between Postgres and SQL Server. Most of the functionality appears to be working, but I ran into a small hiccup with this plugin where it didn't perform JSON column conversions properly on SQL Server.
It looks like the issue has to do with how it's calculating parseOnFetch in the static block for the exported Bookshelf member. Currently it's only set if the client is SQLite, SQLite3, or MySQL. Adding a check for "mssql" leads to the desired behavior on SQL Server as well, though maybe it might make more sense to use client !== 'pg' instead, since only Postgres has a native JSON type?
The text was updated successfully, but these errors were encountered:
MNGoldenEagle
pushed a commit
to MNGoldenEagle/bookshelf-json-columns
that referenced
this issue
Sep 25, 2018
We're using bookshelf as an ORM solution between Postgres and SQL Server. Most of the functionality appears to be working, but I ran into a small hiccup with this plugin where it didn't perform JSON column conversions properly on SQL Server.
It looks like the issue has to do with how it's calculating
parseOnFetch
in the static block for the exported Bookshelf member. Currently it's only set if the client is SQLite, SQLite3, or MySQL. Adding a check for "mssql" leads to the desired behavior on SQL Server as well, though maybe it might make more sense to useclient !== 'pg'
instead, since only Postgres has a native JSON type?The text was updated successfully, but these errors were encountered: