Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON columns parsing with SQLite client #17

Merged
merged 6 commits into from
Jun 7, 2016

Conversation

ricardogama
Copy link
Collaborator

@ricardogama ricardogama commented Jun 4, 2016

This PR adds support for SQLite, parsing JSON columns on fetch.

Closes #16

@ricardogama ricardogama force-pushed the feature/parse-on-fetch-with-sqlite branch 18 times, most recently from 3807cf2 to a6df677 Compare June 6, 2016 12:36
@ricardogama ricardogama force-pushed the feature/parse-on-fetch-with-sqlite branch from a6df677 to 828d9a9 Compare June 6, 2016 12:43
@ricardogama ricardogama mentioned this pull request Jun 6, 2016
2 tasks
@ricardogama ricardogama force-pushed the feature/parse-on-fetch-with-sqlite branch from 828d9a9 to 842c077 Compare June 6, 2016 12:52
@ricardogama ricardogama force-pushed the feature/parse-on-fetch-with-sqlite branch 2 times, most recently from 6d8fc1a to 832b42d Compare June 6, 2016 19:16
import knexfile from './knexfile';
import should from 'should';
import sinon from 'sinon';
import { dropTable, recreateTable } from '../utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort.

await dropTable(repository);
});

describe('if a json column is not registered', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@ricardogama ricardogama force-pushed the feature/parse-on-fetch-with-sqlite branch from 832b42d to e04ed76 Compare June 7, 2016 15:03
@abelsoares abelsoares merged commit de0c008 into master Jun 7, 2016
@abelsoares abelsoares deleted the feature/parse-on-fetch-with-sqlite branch June 7, 2016 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants