Improve contributing section #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Before you start | ||
|
|
||
| - `bookshelf-json-columns` supports PostgreSql and sqlite3. |
There was a problem hiding this comment.
... PostgreSQL and SQLite3.
abelsoares
force-pushed
the
enhancement/readme-contributing-section
branch
from
d61b90b
to
336619d
Compare
| Please follow these advices to keep the pull request workflow simple and to increase the chances of having your PR merged: | ||
|
|
||
| - If you add or enhance functionality, an update of *README.md* usage section should be part of the PR. | ||
| - If your PR fixes a bug you should include tests that at least fails before your code changes and pass after. |
abelsoares
force-pushed
the
enhancement/readme-contributing-section
branch
2 times, most recently
from
075b443
to
4ef21a9
Compare
abelsoares
force-pushed
the
enhancement/readme-contributing-section
branch
from
4ef21a9
to
4f4a356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
README.mdcontributing section.Closes #19.