adding support for sqlite3 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,7 @@ export default Bookshelf => { | |||
| } | |||
| }); | |||
|
|
|||
| if (client === 'sqlite') { | |||
| if (client === 'sqlite' || client === 'sqlite'3) { | |||
There was a problem hiding this comment.
Can you fix the syntax error here?
|
Hi @csepulv! We're also using sqlite3 as dependency to test the plugin with SQLite, you can easily fix this by changing However, the plugin should accept all clients and aliases knex supports, so I'll be glad to merge your PR, cheers! |
|
Good to know about the sqlite change. Sorry about the typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using bookshelf-json-columns and started to use sqlite in memory DB's in my tests. Unfortunately, I ran into some issues as I am using sqlite3 module and not sqlite, so I submit this pull request to add sqlite3