Add project structure #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunorafaelrocha
force-pushed
the
feature/add-project-structure
branch
2 times, most recently
from
1adda32
to
7d5928b
Compare
| { | ||
| "name": "bitreserve/bitreserve-sdk-php", | ||
| "type": "library", | ||
| "description": "Bitreserve SDK PHP for Bitreserve API v0", |
nunorafaelrocha
force-pushed
the
feature/add-project-structure
branch
4 times, most recently
from
5e9bea7
to
5f3b094
Compare
| * | ||
| * @param null|HttpClientInterface $httpClient Bitreserve http client | ||
| */ | ||
| public function __construct($personalAccessToken = null, HttpClientInterface $httpClient = null) |
There was a problem hiding this comment.
Do you need to get the client in the constructor?
|
@nunorafaelrocha please add an |
| */ | ||
| class ErrorException extends \ErrorException implements ExceptionInterface | ||
| { | ||
|
|
| { | ||
| $data = $this->get('/ticker'); | ||
|
|
||
| return array_reduce($data, function($tickers, $ticker) { |
There was a problem hiding this comment.
This is a map, not a reduce.
nunorafaelrocha
force-pushed
the
feature/add-project-structure
branch
4 times, most recently
from
ae94db8
to
867d5f1
Compare
| ->with('/me/transactions') | ||
| ->will($this->returnValue($data)); | ||
|
|
||
| $user = new User($client, array('username' => 'han.solo')); |
nunorafaelrocha
force-pushed
the
feature/add-project-structure
branch
from
867d5f1
to
0e82d57
Compare
| public function getHeader($header = null) | ||
| { | ||
| if ($this->loopCount) { | ||
| $header = sprintf('<https://api.bitreserve.org/%d>; rel="next"', $this->loopCount); |
nunorafaelrocha
force-pushed
the
feature/add-project-structure
branch
from
0e82d57
to
4c089e5
Compare
nunorafaelrocha
force-pushed
the
feature/add-project-structure
branch
from
4c089e5
to
bdd423e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.