Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating symfony/console to 3.2 #152

Closed
wants to merge 2 commits into from

Conversation

bigdawggi
Copy link

Hi there, thanks for writing the Uphold SDK! I notice that to use the SDK with Laravel 5.5.x it's requiring that I update your libraries requirement for symfony/console from ~2.6 to ~3.2.8 (looks like it could be any ~3.0 version, but not tested). I haven't noticed issues running your client with this later version of symfony/console and wonder about getting a pull request moving along to get that console requirement updated.

Any thoughts on your end about doing this?

@bigdawggi
Copy link
Author

hmmm, trying to run phpunit, and can't because composer install tries to install phpdocumentor and that requires symfony/console ~2.3 (so, if I understand correctly, that would go through 2.9.x, but not up to 3.x). So unless we want to drop the phpdocumentor dependency, we're likely not going up to symfony/console 3.x.

@bigdawggi bigdawggi changed the title updating symfony/console to 3.2.8 updating symfony/console to 3.2 Oct 12, 2017
@bigdawggi
Copy link
Author

I went ahead and changed the symfony/console requirement to be ~3.2 instead of ~3.2.8. More what I was meaning ;)

@nunorafaelrocha
Copy link
Collaborator

Hi @bigdawggi, thanks for the pull request. We’ve a lot on our plate. Allow us some time to review and merge this. Thanks

Copy link
Collaborator

@nunorafaelrocha nunorafaelrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigdawggi Please review my comment.

Regarding the phpdocumentor/phpdocumentor dependency we can remove it.

@@ -16,7 +16,7 @@
"php": ">=5.5",
"ext-curl": "*",
"guzzlehttp/guzzle": "~5.1",
"symfony/console": "~2.6"
"symfony/console": "~3.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must continue to have compatibility with lower versions. I suggest the following configuration:

"symfony/console": "~2.6 || ~3.2"

Can you test this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants