Improve tests #93
Merged
Improve tests #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
3 times, most recently
from
15668d6
to
0963b20
Compare
| "phpdocumentor/phpdocumentor": "~2.8.1", | ||
| "phpunit/phpunit": "~4.4.1" | ||
| "phpunit/phpunit": "~4.5", | ||
| "seegno/test-bundle": "^0.0.1" |
There was a problem hiding this comment.
Using ^ instead of ~ here?
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
3 times, most recently
from
fe31462
to
de5492d
Compare
added 10 commits
August 13, 2015 15:16
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
from
de5492d
to
c6b9532
Compare
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
from
c6b9532
to
6b4ac14
Compare
| $login = $this->faker->userName; | ||
| $password = $this->faker->password; | ||
| $description = $this->faker->sentence; | ||
| $login = $this->getFaker()->userName; |
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
from
6b4ac14
to
3ea9f45
Compare
| $login = $this->getFaker()->userName; | ||
| $password = $this->getFaker()->password; | ||
| $description = $this->getFaker()->sentence; | ||
| $otp = $this->getFaker()->randomNumber(6); |
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
from
3ea9f45
to
2acfce6
Compare
| @@ -4,11 +4,12 @@ | |||
|
|
|||
| use Bitreserve\Paginator\ArrayPaginator; | |||
There was a problem hiding this comment.
ArrayPaginator is not being used
added 2 commits
August 14, 2015 11:31
Improve and rename TestCase to ModelTestCase.
nunorafaelrocha
force-pushed
the
enhancement/improve-tests
branch
from
2acfce6
to
aee105f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves tests by adding
SeegnoTestBundleand faker to all test classes.