Fix gemspec and run transpec #220
Conversation
petergoldstein
commented
Apr 7, 2014
petergoldstein
commented
- Fixed gemspec to load by using 'activesupport'
- Updated gemspec to allow more recent versions of RSpec
- Ran transpec to update specs to RSpec 3.x syntax
|
@avit In my reading of Myron's comments the 'x.should ==' pattern is the one that he's trying to eliminate. So I don't really see the point of doing the conversion halfway. What do you get from that? The 'x.should ==' pattern:
At heart, these two issues are what drove the RSpec 3.x syntax change. Given there's question about doing the overall transition, I'd recommend pulling out the gemspec fix and RSpec version upgrade into a separate PR and leaving the transpec changes open for longer discussion. |
|
Yeah, the # ...
describe "next_occurrence" do
subject { schedule.next_occurrence }
it { should be_a Time }
its(:hour) { should == start_time.hour }
context "on a full moon" do
# setup using before / let
it { should == x }
end
endThis is the ExampleGroup version of should (https://github.com/yujinakayama/transpec#two-types-of-should) which is not going away. I'm not 100% either way, but between the "new" RSpec syntax vs. plain Minitest, I'm starting to lean away from RSpec. I don't expect this test suite will change any time soon, and we do have the rspec development gem locked for "< 3.0" anyway. Maybe @seejohnrun has a preference to sway this either way. Yes let's fix the gemspec for sure, I can just cherry-pick that from the other commit instead of bothering with another PR. |
This conversion is done by Transpec 1.10.4 with the following command:
transpec -f
* 583 conversions
from: obj.should
to: expect(obj).to
* 439 conversions
from: == expected
to: eq(expected)
* 13 conversions
from: obj.should_not
to: expect(obj).not_to
* 7 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 3 conversions
from: its(:attr) { }
to: describe '#attr' do subject { super().attr }; it { } end
* 2 conversions
from: Klass.any_instance.should_receive(:message)
to: expect_any_instance_of(Klass).to receive(:message)
* 2 conversions
from: obj.stub!(:message)
to: allow(obj).to receive(:message)
* 2 conversions
from: lambda { }.should
to: expect { }.to
* 1 conversion
from: =~ /pattern/
to: match(/pattern/)
* 1 conversion
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
This conversion is done by Transpec 2.2.1 with the following command:
transpec -f
* 15 conversions
from: == expected
to: eq(expected)
* 15 conversions
from: obj.should
to: expect(obj).to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
|
Rebased and updated gemspec to lock to an RSpec 2.x version for now. |
|
Obviously it's been a while here, but |
|
I don't think a 2+ year old PR is a good basis for a patch, so I'm closing this PR. I don't use this gem anymore, so I'm not the best choice for coming up with a replacement PR. But you should be able to run transpec on an updated master and get a correctly updated result. |
|
Cool thanks Peter
…On Sun, Jan 15, 2017 at 1:11 PM Peter Goldstein ***@***.***> wrote:
Closed #220 <#220>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#220 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD9xUtnKeg-o4Y5yk1amrQhZpILUW-kks5rSmE4gaJpZM4BwHOo>
.
|
