fixes Fixnum deprecation warning for ruby 2.4.0 #364

hwhelchel · 2016-12-29T23:21:17Z

@seejohnrun thanks for a great gem! Would love to add this support for ruby 2.4.0. Let me know if you need any thing else to accept this PR.

Thanks!

See ice-cube-ruby#305

Signed-off-by: Yuri Mikhaylov <me@yurijmi.ru>

hwhelchel · 2016-12-30T16:12:47Z

@seejohnrun looks like the build failed on 2.1 and lower because it's pulling in activesupport-5-0-1 which requires ruby 2.2.2 or higher. Ruby 2.4.0 build failed because rvm couldn't find the ruby version.

seejohnrun · 2017-01-02T16:07:38Z

@hwhelchel hmm - I wonder if we should have a few test files that pull in specific versions? Otherwise we'd need to remove those tests and change the support matrix which I'm not sure I'm ready to do (a lot of people unfortunately still on ruby <2 last I checked)

hwhelchel · 2017-01-02T19:15:18Z

Happy to help fix any issues. I don't understand what is wrong. Looking at the travis 1.9.3 build, the error is

activesupport-5.0.1 requires ruby version >= 2.2.2, which is incompatible with

Do you know why it is trying to pull in the latest version of Active Support?

hwhelchel · 2017-01-05T01:45:53Z

Hmm I can't quite get all 5 builds to pass. Do we need separate gemspecs for each ruby version?

seejohnrun · 2017-01-05T16:28:08Z

I don't think so as long as the Gemfiles don't specify versions.
I am going to take a look at this tonight hopefully and try to see if I can help get this going

seejohnrun · 2017-01-11T13:33:31Z

lib/ice_cube/integer_util.rb

@@ -0,0 +1,9 @@
+module IntegerUtil
+  def self.klass
+    if RUBY_VERSION.include?("2.4.")


I think this probably should be something more concrete / robust - given versions after 2.4 will also have this change. Helpful to look @ rails/rails#25056

seejohnrun · 2017-01-11T13:33:47Z

.travis.yml

@@ -1,6 +1,6 @@
 script: "bundle exec rspec spec"
 before_install:
-  - gem install bundler
+  - gem install bundler && gem update bundler


why this line?

seejohnrun · 2017-01-11T13:34:23Z

lib/ice_cube/time_util.rb

@@ -127,8 +127,8 @@ def self.end_of_date(date, reference=Time.now)
    def self.sym_to_month(sym)
      MONTHS.fetch(sym) do |k|
        MONTHS.values.detect { |i| i.to_s == k.to_s } or
-        raise ArgumentError, "Expecting Fixnum or Symbol value for month. " \
-                             "No such month: #{k.inspect}"
+        raise ArgumentError, "Expecting #{IntegerUtil.klass} or "\


If you're going to change the indentation here, can we just move to one line?

seejohnrun · 2017-01-11T13:58:17Z

Maybe something like s.add_development_dependency('activesupport', ['>= 3.0.0', ('<5' if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new('2.2.2'))].compact) ?

I'm looking for some prior art on how others are handling this but nothing yet

Don't try to bring in new activesupport on versions of Ruby that don't support it

seejohnrun · 2017-01-12T23:30:37Z

FYI I'm testing this idea separately here: #369

Fix tests on older rubies

Also modify `Rule#from_ical` to use `Rule#from_hash` for uniformity and centralization of parsing logic.

Validate rule types while parsing

[TYPO] Fixes a couple of typos in the README.md

Add comment for ical parsing

Fix february in readme example

…le-name Fix incorrect variable name in previous_occurrences.

Add Russian locale

Add Swedish locale

German locale, testing

Raise an ArgumentError if given an empty ical string

…2.4.0

avit · 2017-01-19T22:11:05Z

@hwhelchel Thanks for the contribution. This has a lot of unrelated changes included, could you please rebase and resubmit a clean branch?

I'm also thinking if we could make this class reference static instead of requiring a method call, something like this:

module IceCube
  unless Object.const_defined?(:Integer) && Integer == 1.class
    Integer = Fixnum
  end
end
#=> IceCube::Integer

Then all references to Fixnum could just be changed to Integer and it would find the one from our module if it's defined there.

hwhelchel · 2017-01-19T22:36:46Z

@avit sounds good. I'll take a look at cleaning this up.

patrickjaberg · 2017-03-08T21:23:40Z

@seejohnrun FWIW, it looks like Fixnum is used as a way of validating that arguments are integers. As such, it seems that replacing Fixnum references with Integer may be all that's required. Integer has been around since at least 1.8.7 (I didn't look back further), so I'd think it would be sufficiently backwards compatible for general use. See patrickjaberg@489808f for an example against v0.15.0

I'd be happy to submit a PR if you're interested. Thanks!

seejohnrun · 2017-03-08T21:48:27Z

Yep I'm down for this for sure @patrickjaberg

avit · 2017-03-19T07:27:40Z

Merged #379 instead. Thanks for the contribution.

Thomas and others added 9 commits January 25, 2016 11:46

Add comment for ical parsing

d6f873a

See ice-cube-ruby#305

Fix february in readme example

d09872e

Added russian locale

aced32b

Update Russian locale

dd202e7

Signed-off-by: Yuri Mikhaylov <me@yurijmi.ru>

Add Swedish locale

fc931c3

Signed-off-by: Yuri Mikhaylov <me@yurijmi.ru>

Fix incorrect variable name in previous_occurrences.

033f425

[TYPO] Fixes a couple of typos in the README.md

d102fec

German locale, testing

22bcc01

fixes Fixnum deprecation warning for ruby 2.4.0

d68508c

update bundler in travis

d8467cf

hwhelchel force-pushed the ruby-2.4.0 branch from 292a975 to d8467cf Compare January 5, 2017 13:47

seejohnrun reviewed Jan 11, 2017

View reviewed changes

Fix tests on older rubies

e906888

Don't try to bring in new activesupport on versions of Ruby that don't support it

seejohnrun and others added 10 commits January 13, 2017 09:12

Merge pull request ice-cube-ruby#369 from seejohnrun/test_fix

b5a25ab

Fix tests on older rubies

Validate rule types while parsing

9f4813a

Also modify `Rule#from_ical` to use `Rule#from_hash` for uniformity and centralization of parsing logic.

Added a note to the CHANGELOG

4e1f9b6

Merge pull request ice-cube-ruby#368 from seejohnrun/unsafe_parsing

9f6b909

Validate rule types while parsing

Merge pull request ice-cube-ruby#357 from alexbrinkman/master

10ad93c

[TYPO] Fixes a couple of typos in the README.md

Merge pull request ice-cube-ruby#317 from pocman/patch-1

7bf25bf

Add comment for ical parsing

Merge pull request ice-cube-ruby#331 from fwininger/fix_readme

8098e08

Fix february in readme example

Merge pull request ice-cube-ruby#344 from aquach/fix-incorrect-variab…

820f397

…le-name Fix incorrect variable name in previous_occurrences.

Merge pull request ice-cube-ruby#341 from yurijmi/add-russian-locale

1521132

Add Russian locale

Merge pull request ice-cube-ruby#342 from yurijmi/add-swedish-locale

c08b913

Add Swedish locale

seejohnrun and others added 8 commits January 13, 2017 09:32

Merge pull request ice-cube-ruby#358 from joelmeyerhamme/master

f4af245

German locale, testing

Added a changelog note for translations

04d81c5

Raise an ArgumentError if given an empty ical string

55a2294

Merge pull request ice-cube-ruby#366 from seejohnrun/empty_ical_invalid

e6bceb5

Raise an ArgumentError if given an empty ical string

Added a changelog entry

7b38736

fixes Fixnum deprecation warning for ruby 2.4.0

643d6d9

update bundler in travis

bdc3486

Merge branch 'ruby-2.4.0' of github.com:hwhelchel/ice_cube into ruby-…

08e19b2

…2.4.0

avit closed this Mar 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes Fixnum deprecation warning for ruby 2.4.0 #364

fixes Fixnum deprecation warning for ruby 2.4.0 #364

hwhelchel commented Dec 29, 2016 •

edited

hwhelchel commented Dec 30, 2016

seejohnrun commented Jan 2, 2017

hwhelchel commented Jan 2, 2017

hwhelchel commented Jan 5, 2017

seejohnrun commented Jan 5, 2017

seejohnrun Jan 11, 2017

seejohnrun Jan 11, 2017

seejohnrun Jan 11, 2017

seejohnrun commented Jan 11, 2017

seejohnrun commented Jan 12, 2017

avit commented Jan 19, 2017

hwhelchel commented Jan 19, 2017

patrickjaberg commented Mar 8, 2017

seejohnrun commented Mar 8, 2017

avit commented Mar 19, 2017

fixes Fixnum deprecation warning for ruby 2.4.0 #364

fixes Fixnum deprecation warning for ruby 2.4.0 #364

Conversation

hwhelchel commented Dec 29, 2016 • edited

hwhelchel commented Dec 30, 2016

seejohnrun commented Jan 2, 2017

hwhelchel commented Jan 2, 2017

hwhelchel commented Jan 5, 2017

seejohnrun commented Jan 5, 2017

seejohnrun Jan 11, 2017

Choose a reason for hiding this comment

seejohnrun Jan 11, 2017

Choose a reason for hiding this comment

seejohnrun Jan 11, 2017

Choose a reason for hiding this comment

seejohnrun commented Jan 11, 2017

seejohnrun commented Jan 12, 2017

avit commented Jan 19, 2017

hwhelchel commented Jan 19, 2017

patrickjaberg commented Mar 8, 2017

seejohnrun commented Mar 8, 2017

avit commented Mar 19, 2017

hwhelchel commented Dec 29, 2016 •

edited