Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic profile support #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhornbacher
Copy link

@mhornbacher mhornbacher commented Mar 30, 2023

Summary

Basic support for AWS profiles as per #17

Example

steps:
  - commands: 'echo \$SECRET_FROM_OTHER_REGION'
    plugins:
      - seek-oss/aws-sm#v2.3.1:
          profile: profile-name
          env:
            SECRET_FROM_OTHER_PROFILE: my-secret-id

Limitations

This Pull Request does not support separate profiles per secret. Due to how env secrets are loaded this would require a much larger and therefore riskier refactor.

Closes #17

@mhornbacher mhornbacher changed the title feat: add basic region support feat: add basic profile support Mar 30, 2023
@mhornbacher mhornbacher marked this pull request as ready for review March 30, 2023 18:32
@mhornbacher
Copy link
Author

@72636c this is a minor blocker for us. Would it be possible to get a review done by April 10?

@jmandel1027
Copy link

Whoops! I thought this was on our end

@mhornbacher
Copy link
Author

Thanks for the vote of confidence :)

@mhornbacher
Copy link
Author

Looks like nothing has happened here in two years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS profiles
2 participants