Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuRenderer: Guard against open/close handlers firing incorrectly #1088

Merged
merged 4 commits into from Apr 7, 2022

Conversation

michaeltaranto
Copy link
Contributor

No description provided.

@michaeltaranto michaeltaranto requested a review from a team as a code owner April 6, 2022 23:54
@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2022

🦋 Changeset detected

Latest commit: eccfbd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one non-blocking nitpick.

lib/components/MenuRenderer/MenuRenderer.tsx Outdated Show resolved Hide resolved
@michaeltaranto michaeltaranto enabled auto-merge (squash) April 7, 2022 00:48
@michaeltaranto michaeltaranto merged commit 14afb89 into master Apr 7, 2022
@michaeltaranto michaeltaranto deleted the menurenderer-guard branch April 7, 2022 00:55
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants