Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to monorepo #1136

Merged
merged 67 commits into from Aug 17, 2022
Merged

Convert to monorepo #1136

merged 67 commits into from Aug 17, 2022

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Aug 15, 2022

Things to test (feel free to add to this list):

  • The codemod (braid-upgrade) is still shipped with braid-design-system, and it works
  • Docs site deployment
  • Playroom (Only works locally, TypeError: c.jsxDEV is not a function on preview site) Fixed
  • Releases page (showing patch changes from some test changesets I made a while ago) Fixed
  • Gallery
  • Changeset workflow still works.
  • Snapshot deployments

A snapshot version of braid-design-system was tested with:

Should we test it with some more repos?

Notes:

  • We discovered that react-dom was only a dev dep but should've been a peer dep as it's used within BraidPortal, hence the changeset

@askoufis askoufis requested a review from a team as a code owner August 15, 2022 02:08
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

🦋 Changeset detected

Latest commit: e57b498

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equally epic and exciting!

Great work 👏 🚀

@askoufis askoufis merged commit 2ba6162 into master Aug 17, 2022
@askoufis askoufis deleted the monorepo branch August 17, 2022 03:52
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants