New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to monorepo #1136
Merged
Convert to monorepo #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reat` alias from sku config as it's not needed any more
🦋 Changeset detectedLatest commit: e57b498 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Tweak `.gitignore`s and `.prettierignore` - Remove unused deps - Move `chromatic` dep to `braid-design-system` package, add script for it - Clean up some imports - Add `@seek` scope to `generate-component-docs` package
michaeltaranto
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Equally epic and exciting!
Great work 👏 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to test (feel free to add to this list):
braid-upgrade
) is still shipped withbraid-design-system
, and it works(Only works locally,FixedTypeError: c.jsxDEV is not a function
on preview site)(showing patch changes from some test changesets I made a while ago)FixedA snapshot version of
braid-design-system
was tested with:Should we test it with some more repos?
Notes:
react-dom
was only a dev dep but should've been a peer dep as it's used withinBraidPortal
, hence the changeset