New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading: Nested icons inherit text colour #1153
Conversation
🦋 Changeset detectedLatest commit: c4a7694 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive cleanup 👏
Just a few semi-nitpicky comments from me 👼
When using icons inside of a
Heading
, the defaulttone
was alwaysneutral
, rather than inheriting the colour of the nearest component.For example, when an icon was used inside of a
TextLink
within aHeading
:or equally, when an icon was used inside of a
Secondary
component within aHeading
: