Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading: Nested icons inherit text colour #1153

Merged
merged 4 commits into from Sep 29, 2022
Merged

Conversation

michaeltaranto
Copy link
Contributor

When using icons inside of a Heading, the default tone was always neutral, rather than inheriting the colour of the nearest component.

For example, when an icon was used inside of a TextLink within a Heading:

<Heading level="1">
  Title with <TextLink>link <IconArrow /></TextLink>
</Heading>
// => Previously, IconArrow was the heading text colour
// `neutral`, now inherits the `link` colour.

or equally, when an icon was used inside of a Secondary component within a Heading:

<Heading level="1">
  Title with <Secondary>secondary <IconArrow /></Secondary>
</Heading>
// => Previously, IconArrow was the heading text colour
// `neutral`, now inherits the `secondary` colour.

@michaeltaranto michaeltaranto requested a review from a team as a code owner September 28, 2022 00:05
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

🦋 Changeset detected

Latest commit: c4a7694

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@mrm007 mrm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive cleanup 👏

Just a few semi-nitpicky comments from me 👼

@michaeltaranto michaeltaranto merged commit 32cd661 into master Sep 29, 2022
@michaeltaranto michaeltaranto deleted the text-styling-cleanup branch September 29, 2022 00:40
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants