Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme tokens for shape of font metrics #1214

Merged
merged 1 commit into from Feb 6, 2023

Conversation

michaeltaranto
Copy link
Contributor

Internally some theme utilities were using Capsize’s FontMetrics as their expected payload, rather than correctly using the shape of the theme tokens. This makes Braid compatible with Capsize v3.x.

@michaeltaranto michaeltaranto requested a review from a team as a code owner February 6, 2023 04:19
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

🦋 Changeset detected

Latest commit: cca0410

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto michaeltaranto enabled auto-merge (squash) February 6, 2023 04:20
@michaeltaranto michaeltaranto merged commit 30790c9 into master Feb 6, 2023
@michaeltaranto michaeltaranto deleted the fix-metrics-in-theme-utils branch February 6, 2023 04:39
@seek-oss-ci seek-oss-ci mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants