Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert, useToast: Design update #1269

Merged
merged 2 commits into from Apr 3, 2023
Merged

Alert, useToast: Design update #1269

merged 2 commits into from Apr 3, 2023

Conversation

michaeltaranto
Copy link
Contributor

Alert

Refine the design to use consistent horizontal container inset, aligning content with elements like Card, as well as simplifying the design by removing the sidebar/keyline (consistent with useToast).

Before

After

useToast

As a means to increase constrast against page content, the design has been updated to be presented on inverted backgrounds based on the color mode.
The design has also be refined to remove the sidebar/keyline (consistent with Alert), while also applying the tone to the provided message.

Before

After

Before

After

@michaeltaranto michaeltaranto requested a review from a team as a code owner April 3, 2023 05:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: bbaf97e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis
Copy link
Contributor

askoufis commented Apr 3, 2023

Is the toast action label weight changing to weak intentional? I can't see the change in the code, so I'm not sure how it's happening.

@michaeltaranto
Copy link
Contributor Author

Yep, it is moving to a weak link as a result inline with the contextual rules built into TextLink — now that it is on surfaceDark it defaults to weak.

We could force regular weight, but the design decision is to run with weak

@michaeltaranto michaeltaranto merged commit 8845603 into master Apr 3, 2023
5 checks passed
@michaeltaranto michaeltaranto deleted the alert-toast-design branch April 3, 2023 22:05
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants