Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button, ButtonLink: Align border width with field border width #1274

Merged
merged 2 commits into from Apr 5, 2023

Conversation

michaeltaranto
Copy link
Contributor

Button, ButtonLink

Align the border width of ghost variants with the border width of fields.
This is the final re-alignment piece to ensure all components use theme scales consistently, improving the ability of Braid themes to deliver cohesive design uplift.

Before:
Preview before

After:
Preview after

Box, atoms

Add borderBrandAccent and borderBrandAccentLight to the available boxShadows, combining the brandAccent brandAccentLight border colours with the standard border width token.
Previously, brandAccent was only available with the large border width.

EXAMPLE USAGE:

<Box boxShadow="borderBrandAccent" />
{/* or */}
<Box boxShadow="borderBrandAccentLight" />
import { atoms } from 'braid-design-system/css';

atoms({ boxShadow: 'borderBrandAccent' });
atoms({ boxShadow: 'borderBrandAccentLight' });

@michaeltaranto michaeltaranto requested a review from a team as a code owner April 5, 2023 05:58
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: 12cf64b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@michaeltaranto michaeltaranto merged commit ea8cb68 into master Apr 5, 2023
5 checks passed
@michaeltaranto michaeltaranto deleted the align-button-field-border branch April 5, 2023 11:37
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants