Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea: Adjust highlightRange background height #1279

Merged
merged 1 commit into from Apr 11, 2023

Conversation

michaeltaranto
Copy link
Contributor

Remove the vertical padding on the highlight element to prevent the background colour overlapping the wavy underline in themes with tighter line heights.

@michaeltaranto michaeltaranto requested a review from a team as a code owner April 11, 2023 00:31
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

🦋 Changeset detected

Latest commit: c773ba7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto michaeltaranto merged commit 53f53ec into master Apr 11, 2023
5 checks passed
@michaeltaranto michaeltaranto deleted the textarea-highlight-fix branch April 11, 2023 00:45
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants