Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabPanel: Align focus outline radius to scale #1345

Merged
merged 1 commit into from Aug 21, 2023
Merged

Conversation

michaeltaranto
Copy link
Contributor

Increase the radius of the focus outline to better align to the scale. A TabPanel is typically a "large" element containing entire sections of UI, so using the large radius to better align to the radius scale.

Screenshots

Example of before and after with the tab panel focused:

@michaeltaranto michaeltaranto requested a review from a team as a code owner August 21, 2023 05:46
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

🦋 Changeset detected

Latest commit: 30acdb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jahredhope jahredhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear reasoning, thanks.

@michaeltaranto michaeltaranto merged commit ad0c71c into master Aug 21, 2023
8 checks passed
@michaeltaranto michaeltaranto deleted the tabpanel-radius branch August 21, 2023 22:40
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants