Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target ECR registry by Account ID and Region #20

Merged
merged 5 commits into from
May 26, 2020

Commits on May 22, 2020

  1. Ability to specify both region and account ID of ECR registry

    For our use case we store all of our ECR repositories in a single
    account, and access these repos from others. Therefore we require the
    need to specify the account which possess the repostories, along with
    the region.
    
    The region wasn't a necessary change however I have seen others
    requesting this and it was an easy implementation alongside this work.
    HenryCook committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d872c3e View commit details
    Browse the repository at this point in the history
  2. Amend default region variable

    Reason for this is because when trying to grab the region via the means
    previously implemented it was unsuccessful on a Buildkite agent running
    on EC2.
    
    As we have changed to using `get-login-password` due to the previous
    implementation being deprecated, it requires the region as well as the
    account id to be given as part of the docker login command.
    
    Ideally I would leave the region out of these changes entirely.
    
    If nothing is given both via the `region` flag or `AWS_DEFAULT_REGION`
    env var, it will default to `eu-west-1`.
    HenryCook committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d4f04fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abe770a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f2b382b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Configuration menu
    Copy the full SHA
    8a355ef View commit details
    Browse the repository at this point in the history