feat: prevent objects with serializers from being trimmed #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fastify request/response objects are classes with getters, which rely on serializers to call them. The
dtrim
library was previously destroying the classes before they reach the serializer. This change prevents any objects/classes with a serializer from being trimmed.Approach
dtrim
to version which includes aretain
option.pino-std-serializers
to adderrWithCause
serializer.Notes
Adding
stdSerializers
directly to the serializers were adding non serializers to pino. https://github.com/pinojs/pino-std-serializers/blob/986ef19e19b9d68c2e821d948f066362a4f82311/index.d.ts#L109Issues