Make wait in assertCodePaneLineCount an optional prop

seek-oss · May 10, 2024 · 6dd7da1 · 6dd7da1
1 parent 766098e
commit 6dd7da1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/cypress/e2e/snippets.cy.js b/cypress/e2e/snippets.cy.js
@@ -72,7 +72,7 @@ describe('Snippets', () => {
     assertSnippetsListIsVisible();
     assertCodePaneLineCount(8);
     filterSnippets('{esc}');
-    assertCodePaneLineCount(1);
+    assertCodePaneLineCount(1, { wait: 500 });
     typeCode(`${isMac() ? '{cmd}' : '{ctrl}'}k`);
     assertSnippetsListIsVisible();
     assertCodePaneLineCount(8);
@@ -89,7 +89,7 @@ describe('Snippets', () => {
     // Close without persisting
     filterSnippets('{esc}');
     assertCodePaneContains('<div>Initial <span>code</span></div>');
-    assertCodePaneLineCount(1);
+    assertCodePaneLineCount(1, { wait: 500 });
 
     // Re-open and persist
     typeCode(`${isMac() ? '{cmd}' : '{ctrl}'}k`);

diff --git a/cypress/support/utils.js b/cypress/support/utils.js
@@ -149,13 +149,15 @@ export const assertCodePaneContains = (text) => {
   });
 };
 
-export const assertCodePaneLineCount = (lines) => {
+export const assertCodePaneLineCount = (lines, { wait } = {}) => {
   getCodeEditor().within(() =>
     cy.get('.CodeMirror-line').should('have.length', lines)
   );
 
   // Wait after check to ensure original focus is restored
-  cy.wait(500); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting
+  if (typeof wait === 'number') {
+    cy.wait(wait);
+  }
 };
 
 export const assertFramesMatch = (matches) =>