Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve frameSrc not found warning #165

Merged
merged 2 commits into from Jun 2, 2020
Merged

Conversation

mattcompiles
Copy link
Contributor

@mattcompiles mattcompiles commented Jun 2, 2020

Resolves #164

@mattcompiles mattcompiles requested a review from a team as a code owner June 2, 2020 02:27
@mattcompiles mattcompiles merged commit 28b1f9a into master Jun 2, 2020
@mattcompiles mattcompiles deleted the fix-framesrc-warning branch June 2, 2020 02:48
@maraisr
Copy link
Contributor

maraisr commented Jun 2, 2020

Wait... I get it! So this "frameSrc" is something I can export from my frame component housed file? @mattcompiles

@mattcompiles
Copy link
Contributor Author

That's correct.

@maraisr
Copy link
Contributor

maraisr commented Jun 2, 2020

Do you think you can help me with a list of things that are undocumented with Playroom, so I can help you guys out in writing some. cc @mattcompiles @michaeltaranto @markdalgleish

@michaeltaranto
Copy link
Contributor

This is currently a feature we are proving out, so it's deliberately undocumented at this point. We are hoping to get to building a site soon, but was there something else on your list?

@maraisr
Copy link
Contributor

maraisr commented Jun 2, 2020

Generally speaking new features that are being tested get released under an @next tag, rather than the stable. Perhaps playroom could do something similar?

And re the list, I was hoping you could provide one.

@michaeltaranto
Copy link
Contributor

Worth remembering that Playroom is pre-1.0, so everything is a next tag.

We document the features that we are happy for users to start consuming. If consumers are digging into the code and using internal apis, that's fine as they are explicitly opting in to an unstable api.

@maraisr
Copy link
Contributor

maraisr commented Jun 3, 2020

Oh right... Did not know that that 0.x.x means beta. My bad!

@maraisr
Copy link
Contributor

maraisr commented Jun 3, 2020

Pretty funny hey.

@maraisr
Copy link
Contributor

maraisr commented Jun 3, 2020

... I'm serious.

@seek-oss seek-oss locked as resolved and limited conversation to collaborators Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frameSrc was not found in __PLAYROOM_ALIAS__FRAME_COMPONENT__
3 participants