-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to Webpack 5 #218
Conversation
f30372b
to
d1a8d79
Compare
- fix lint and type errors - downgrade webpack-dev-server
fix: make the project run and compile
Downgrading husky so the existing config works
Had some time tonight to dig in to the Cypress test failures, |
Getting an error of not having the plugin installed in a consuming app so have moved node-polyfill-webpack-plugin to regular dependencies.
Can somebody from maintainers please take a look at this PR? |
Hey 👋, Sorry we haven't had bandwidth to look into this. Our main concern here is maintaining compatibility with webpack 4 as a lot of consumers are still using it. Not sure how difficult it would be to support both but otherwise we'll need to do a breaking change. Also there are a lot of changes in this PR that seem unrelated to webpack 5 which makes it a bit hard to review. |
Thanks all! 🎉 |
Working towards a fix for #215.
Our stack is React 17 with Treat, with our docs running on Gatsby.
The error I'm stuck on is getting pulled up in each imported component:
As well as the following which I'm pretty sure are just based on the Webpack builds failing per compnent:
Have published a smurf package to
loliver-test-playroom
as I was getting issues with multiple Webpack installs.Hoping there are others out there that this can help and we can get to a solution.
Cheers.