Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade webpack-dev-server #240

Merged

Conversation

mihkeleidast
Copy link
Contributor

@mihkeleidast mihkeleidast commented Sep 13, 2021

Upgrades webpack-dev-server to latest in order to resolve two npm deprecation warnings when installing playroom:

npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.

Not sure if there are any actual issues on Node 14 when using older webpack-dev-server, but I like to be better safe than sorry and not introduce issues into our codebase.

Last one from me for today, ran into these four issues when installing :)

@mihkeleidast mihkeleidast requested a review from a team as a code owner September 13, 2021 12:38
Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks for being so thorough 👏

@michaeltaranto michaeltaranto enabled auto-merge (squash) September 24, 2021 11:38
@michaeltaranto michaeltaranto merged commit 143d4ef into seek-oss:master Sep 24, 2021
@mihkeleidast mihkeleidast deleted the update-webpack-dev-server branch September 30, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants