Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore invalid exported components #140

Merged
merged 12 commits into from Oct 19, 2020
Merged

fix: Ignore invalid exported components #140

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f2ac4a2
fix: Introduce a broken example
fwouts Mar 27, 2020
cb0d7e6
fix: Filter out invalid React components
fwouts Mar 27, 2020
fc7ca25
fix: Add a helpful comment
fwouts Mar 27, 2020
6ef5b13
fix: Ensure that promise is returned in Cypress chain
fwouts Apr 6, 2020
16dad87
Merge branch 'master' into 138-typescript-crash
michaeltaranto Apr 22, 2020
4fa8089
Merge branch 'master' into 138-typescript-crash
michaeltaranto Apr 23, 2020
37665ea
Merge branch 'master' into 138-typescript-crash
fwouts May 24, 2020
fe96468
fix: Formatting
fwouts May 24, 2020
c086163
fix: Remove return statement for conciseness
fwouts May 24, 2020
3bc9b7c
Merge branch 'master' into 138-typescript-crash
fwouts Jul 10, 2020
e22057e
Merge remote-tracking branch 'origin/master' into 138-typescript-crash
fwouts Oct 19, 2020
e6d3686
fix: Simplify 💥
fwouts Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/index.js
View file
Open in desktop
Expand Up @@ -18,11 +18,16 @@ polyfillIntersectionObserver().then(() => {

const renderPlayroom = ({
themes = require('./themes'),
components = require('./components'),
importedComponents = require('./components'),
snippets = require('./snippets'),
} = {}) => {
const themeNames = Object.keys(themes);

// Exclude undefined components, e.g. an exported TypeScript type.
const components = Object.fromEntries(
Object.entries(importedComponents).filter(([_, value]) => value)
);

render(
<StoreProvider themes={themeNames} widths={widths}>
<Playroom
Expand Down